Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Anthropic compatible with new ChatMessage; fix prompt caching tests #1252

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: make Anthropic compatible with new ChatMessage; fix prompt caching tests #1252

merged 2 commits into from
Dec 18, 2024
+12 −5

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Dec 18, 2024 •
edited
Loading

Related Issues

Proposed Changes:

  • make the Chat Generator compatible with both new and old ChatMessage (this is temporary: we will port soon the Chat Generator with Tool support from experimental)
  • fix prompt caching tests

How did you test it?

CI

Checklist

@anakin87 anakin87 changed the title make Anthropic compatible with new chatmessage; fix prompt caching tests fix: make Anthropic compatible with new ChatMessage; fix prompt caching tests Dec 18, 2024
@anakin87 anakin87 marked this pull request as ready for review December 18, 2024 11:22
@anakin87 anakin87 requested a review from a team as a code owner December 18, 2024 11:22
@anakin87 anakin87 requested review from davidsbatista and julian-risch and removed request for a team December 18, 2024 11:22
@anakin87 anakin87 mentioned this pull request Dec 18, 2024
Merged
@vblagoje vblagoje self-requested a review December 18, 2024 13:52
vblagoje
vblagoje approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit b12461d into main Dec 18, 2024
10 checks passed
@anakin87 anakin87 deleted the fix-anthropic-new-chatmsg branch December 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@davidsbatista davidsbatista Awaiting requested review from davidsbatista davidsbatista is a code owner automatically assigned from deepset-ai/open-source-engineering

@julian-risch julian-risch Awaiting requested review from julian-risch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @vblagoje